Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Decimal Arithmetic #2881

Merged
merged 5 commits into from
Oct 29, 2022
Merged

Add Decimal Arithmetic #2881

merged 5 commits into from
Oct 29, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Oct 15, 2022

Which issue does this PR close?

Follow on to #2770

Rationale for this change

What changes are included in this PR?

Adds support to the arithmetic kernels for decimal arrays. It is worth noting that these ignore precision and scale, it is up to the user to ensure the arrays have valid data types. Dyn kernels will follow in a subsequent PR.

Are there any user-facing changes?

No

FYI @kmitchener

@github-actions github-actions bot added the arrow Changes to the arrow crate label Oct 15, 2022
@viirya
Copy link
Member

viirya commented Oct 15, 2022

Oh, some traits need to be implemented for i256:

   --> arrow/src/datatypes/numeric.rs:471:17
    |
471 |     type Simd = i256;
    |                 ^^^^ no implementation for `arrow_buffer::i256 + arrow_buffer::i256`
    |
    = help: the trait `Add` is not implemented for `arrow_buffer::i256`

@tustvold tustvold marked this pull request as draft October 16, 2022 05:02
@liukun4515
Copy link
Contributor

after this merged, we can replace this op in the datafusion for decimal data type

@tustvold tustvold marked this pull request as ready for review October 29, 2022 02:33
@tustvold tustvold merged commit e6eb834 into apache:master Oct 29, 2022
@ursabot
Copy link

ursabot commented Oct 29, 2022

Benchmark runs are scheduled for baseline = 87c9db4 and contender = e6eb834. e6eb834 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants