Generic bytes dictionary builder #3426
Conversation
| where | ||
| <T as ByteArrayType>::Native: AsRef<<T as ByteArrayType>::Native> + AsRef<[u8]>, |
There was a problem hiding this comment.
It took me a long while to work out why this is necessary, and it is because there isn't a blanket implementation of T: AsRef<T>.
I wonder if we could add this constraint to ByteArrayType directly, and allow removing this constraint?
type Native: bytes::ByteArrayNativeType + AsRef<Self::Native> + AsRef<[u8]> + ?Sized;
There was a problem hiding this comment.
Yea, that works to remove the constraint.
…g and large binary.
| @@ -609,7 +612,7 @@ where | |||
| })?; | |||
|
|
|||
| if array.is_valid(index) { | |||
| let s = array.value(index).as_ref(); | |||
| let s: &[u8] = array.value(index).as_ref(); | |||
There was a problem hiding this comment.
Does this technically mean this is an API change? That's kind of unintentional, but not necessarily a problem 😅
Co-authored-by: Raphael Taylor-Davies <[email protected]>
|
Benchmark runs are scheduled for baseline = 6139d89 and contender = 08a976f. 08a976f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3425.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?