Ignore array::array_primitive::tests::test_time32second_invalid_neg during MIRI run #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One MIRI run ran: https://github.com/apache/arrow-rs/pull/346/checks?check_run_id=2659776208 successfully. Rekicking to see about another |
|
This time MIRI failed: https://github.com/apache/arrow-rs/pull/346/checks?check_run_id=2668065552 Not a good solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #345 (maybe)
Rationale for this change
It isn't entirely clear to me, but part of the stacktrace that is dumped on MIRI failure contains this test. I am testing what happens if we just disable running this test during the MIRI run
What changes are included in this PR?
Disable a suspicious test when running under MIRI
Are there any user-facing changes?
No