Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: add ticket links to failing ipc integration tests #3461

Merged
merged 1 commit into from
Jan 5, 2023
+7 −5
Merged

Minor: add ticket links to failing ipc integration tests #3461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions arrow-integration-testing/tests/ipc_reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,11 @@ fn read_1_0_0_bigendian() {

FileReader::try_new(file, None).unwrap();

// While the the reader doesn't error but the values are not read correctly
// so verifing the contents fails
// While the the reader doesn't error but the values are not
// read correctly on little endian platforms so verifing the
// contents fails
//
// https://github.com/apache/arrow-rs/issues/3459
//verify_arrow_file(&testdata, "1.0.0-bigendian", path);
});
}
Expand All @@ -117,8 +120,7 @@ fn read_1_0_0_littleendian() {
"generated_extension",
"generated_interval",
"generated_map",
// fails with
// thread 'read_1_0_0_littleendian' panicked at 'assertion failed: `(left == right)`
// https://github.com/apache/arrow-rs/issues/3460
//"generated_map_non_canonical",
"generated_nested",
"generated_nested_dictionary",
Expand Down
2 changes: 1 addition & 1 deletion arrow-integration-testing/tests/ipc_writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ fn write_1_0_0_littleendian() {
"generated_extension",
"generated_interval",
"generated_map",
// thread 'write_1_0_0_littleendian' panicked at 'assertion failed: `(left == right)`
// https://github.com/apache/arrow-rs/issues/3460
// "generated_map_non_canonical",
"generated_nested",
"generated_nested_dictionary",
Expand Down