Fix CSV infinite loop and improve error messages #3470
Conversation
| fn fill_buf(&mut self, to_read: usize) -> Result<(), ArrowError> { | ||
| /// Clears and then fills the buffers on this [`RecordReader`] | ||
| /// returning the number of records read | ||
| fn fill_buf(&mut self, to_read: usize) -> Result<usize, ArrowError> { |
There was a problem hiding this comment.
I reworked this to return the quantity read as I thought this made for a slightly clearer API
arrow-csv/src/reader/records.rs
Outdated
| /// Skips forward `to_skip` rows | ||
| pub fn skip(&mut self, mut to_skip: usize) -> Result<(), ArrowError> { | ||
| pub fn skip(&mut self, to_skip: usize) -> Result<(), ArrowError> { |
There was a problem hiding this comment.
Maybe we can document the error behavior.
|
Benchmark runs are scheduled for baseline = 39eeeaf and contender = b39a20a. b39a20a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #3467
Closes #3469
Rationale for this change
See tickets
What changes are included in this PR?
Are there any user-facing changes?