Allow StringArray
construction with Vec<Option<String>>
#3602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3599
Rationale for this change
This is an ergonomic addition, allows StringArrays to be constructed from more types (specifically Vec<Option> here.
What changes are included in this PR?
Added the impl, and fixed the tests that were ambiguous.
Are there any user-facing changes?
If a user tries to make a StringArray completely out of None values, before they could rely on it being inferred to a
Vec<Option<&str>>
impl. Now they must specify that (as shown in the test fixes).This is possibly considered a breaking change.
Thanks!!