Rename list contains kernels to in_list (#4289) #4342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jun 2, 2023
mcheshkov
added a commit
to cube-js/arrow-rs
that referenced
this pull request
Aug 27, 2024
Can drop this after rebase on commit 7952595 "Rename list contains kernels to in_list (apache#4289) (apache#4342)", first released in 41.0.0
mcheshkov
added a commit
to cube-js/arrow-rs
that referenced
this pull request
Aug 27, 2024
Can drop this after rebase on commit 7952595 "Rename list contains kernels to in_list (apache#4289) (apache#4342)", first released in 41.0.0
mcheshkov
added a commit
to cube-js/arrow-rs
that referenced
this pull request
Aug 27, 2024
Can drop this after rebase on commit 7952595 "Rename list contains kernels to in_list (apache#4289) (apache#4342)", first released in 41.0.0
mcheshkov
added a commit
to cube-js/arrow-rs
that referenced
this pull request
Aug 27, 2024
Can drop this after rebase on commit 7952595 "Rename list contains kernels to in_list (apache#4289) (apache#4342)", first released in 41.0.0
mcheshkov
added a commit
to cube-js/arrow-rs
that referenced
this pull request
Sep 5, 2024
Can drop this after rebase on commit 7952595 "Rename list contains kernels to in_list (apache#4289) (apache#4342)", first released in 41.0.0
mcheshkov
added a commit
to cube-js/arrow-rs
that referenced
this pull request
Sep 5, 2024
Can drop this after rebase on commit 7952595 "Rename list contains kernels to in_list (apache#4289) (apache#4342)", first released in 41.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4289
Rationale for this change
#3502 added contains string comparison kernels. These overlapped with similarly named kernels for list membership. This would have prevented anyone from using these kernels via the re-exports in the top-level arrow crate, and as of the latest Rust results in a compiler warning on build.
I opted to rename the older kernel as:
What changes are included in this PR?
Are there any user-facing changes?
Yes two kernels are renamed