Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate output of MIRI is successful on CI #578

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 20, 2021

Closes #581

Rationale for this change

We started running MIRI again in #421, but while discussing with @jorgecarleitao
on jorgecarleitao/arrow2#209, it turned out that we were still ||true ing the output (aka not validating that MIRA was running cleanly)

What changes are included in this PR?

Check output of MIRI return

Are there any user-facing changes?

No

@alamb alamb added the development-process Related to development process of arrow-rs label Jul 20, 2021
@alamb alamb changed the title Validate output of MIRI Validate output of MIRI is successful on CI Jul 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #578 (2049c28) into master (68a4b5b) will not change coverage.
The diff coverage is n/a.

❗ Current head 2049c28 differs from pull request most recent head adc189d. Consider uploading reports for the commit adc189d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #578   +/-   ##
=======================================
  Coverage   82.46%   82.46%           
=======================================
  Files         167      167           
  Lines       46205    46205           
=======================================
  Hits        38101    38101           
  Misses       8104     8104           
Impacted Files Coverage Δ
arrow/src/array/ffi.rs 100.00% <ø> (ø)
arrow/src/compute/kernels/sort.rs 94.15% <ø> (ø)
arrow/src/datatypes/ffi.rs 72.86% <ø> (ø)
arrow/src/ffi.rs 87.07% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a4b5b...adc189d. Read the comment docs.

arrow/src/array/ffi.rs Outdated Show resolved Hide resolved
@alamb alamb force-pushed the alamb/validate_output_of_miri branch from adc189d to 2ed25c7 Compare July 21, 2021 13:22
@alamb
Copy link
Contributor Author

alamb commented Jul 21, 2021

FYI @jorgecarleitao @nevi-me and @roee88 -- I am merging this PR in so that we do not allow MIRI failures in again on CI 🎉

@alamb alamb merged commit 30f1b1f into apache:master Jul 21, 2021
@alamb alamb deleted the alamb/validate_output_of_miri branch July 25, 2021 11:44
alamb added a commit that referenced this pull request Jul 25, 2021
alamb added a commit that referenced this pull request Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure output of MIRI is checked for success
2 participants