Implement StringBuilder::append_option
#601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 25, 2021
There was a problem hiding this comment.
Thank you @mzeitlin11 -- this looks great!
please let me know if this should be added to the CHANGELOG
This will automatically get added to the changelog by our scripts. There is no need to do anything else
cc @tzzed
| let mut builder = StringBuilder::new(20); | ||
| builder.append_option(Some("hello")).unwrap(); | ||
| builder.append_option(None::<&str>).unwrap(); | ||
| builder.append_option(None::<String>).unwrap(); |
Codecov Report
@@ Coverage Diff @@
## master #601 +/- ##
=======================================
Coverage 82.41% 82.41%
=======================================
Files 167 167
Lines 46232 46249 +17
=======================================
+ Hits 38100 38118 +18
+ Misses 8132 8131 -1
Continue to review full report at Codecov.
|
alamb
pushed a commit
that referenced
this pull request
Jul 25, 2021
alamb
added a commit
that referenced
this pull request
Jul 26, 2021
* Implement StringBuilder::append_option * Add another null append tesT Co-authored-by: Matthew Zeitlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #263.
Are there any user-facing changes?
Addition of a new method,
StringBuilder::append_option(please let me know if this should be added to the CHANGELOG)