Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick support struct array in pretty display to active_release #609

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 25, 2021

Automatic cherry-pick of 87d2840

* support struct array in pretty display

* print null value as null

to be consistent with postgresql

* add test for struct array pretty print

* Revert "print null value as null"

This reverts commit 3d620f6.

* handle null value as sepcial case in struct display
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2021

Codecov Report

Merging #609 (691feb7) into active_release (8835adc) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           active_release     #609      +/-   ##
==================================================
- Coverage           82.45%   82.40%   -0.05%     
==================================================
  Files                 167      167              
  Lines               46203    46230      +27     
==================================================
  Hits                38098    38098              
- Misses               8105     8132      +27     
Impacted Files Coverage Δ
arrow/src/util/display.rs 24.03% <0.00%> (-8.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8835adc...691feb7. Read the comment docs.

@alamb alamb merged commit e0d1d5b into active_release Jul 26, 2021
@alamb alamb deleted the cherry_pick_87d28400 branch July 26, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants