Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update object store MSRV to 1.64 #6123

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Update object store MSRV to 1.64 #6123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d8b69d
Update MSRV to 1.64
alamb Jul 25, 2024
3e2c236
Revert "clippy ignore"
alamb Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion object_store/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ readme = "README.md"
description = "A generic object store interface for uniformly interacting with AWS S3, Google Cloud Storage, Azure Blob Storage and local files."
keywords = ["object", "storage", "cloud"]
repository = "https://github.com/apache/arrow-rs/tree/master/object_store"
rust-version = "1.62.1"
rust-version = "1.64.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears we are using something that requires Rust 1.64: https://github.com/apache/arrow-rs/actions/runs/10099988786/job/27930338500?pr=6120

Since Rust 1.64 was released almost 2 years ago (September 2022) I think it is safe to upgrade


[package.metadata.docs.rs]
all-features = true
Expand Down
2 changes: 0 additions & 2 deletions object_store/src/client/mock_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ impl MockServer {
let mut set = JoinSet::new();

loop {
// https://github.com/apache/arrow-rs/issues/6122
#[allow(clippy::incompatible_msrv)]
let (stream, _) = tokio::select! {
conn = listener.accept() => conn.unwrap(),
_ = &mut rx => break,
Expand Down
Loading