Cherry pick Allow casting Timestamp arrays into String to active_release #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the change adds uses the existing `PrimitiveArray::value_as_datetime` to support casting from `Timestamp(_,_)` to ``[Large]Utf8`.
Codecov Report
@@ Coverage Diff @@
## active_release #698 +/- ##
==================================================
+ Coverage 82.39% 82.40% +0.01%
==================================================
Files 167 167
Lines 46568 46600 +32
==================================================
+ Hits 38371 38403 +32
Misses 8197 8197
Continue to review full report at Codecov.
|
ovr
pushed a commit
to cube-js/arrow-rs
that referenced
this pull request
Aug 25, 2022
…e#698) the change adds uses the existing `PrimitiveArray::value_as_datetime` to support casting from `Timestamp(_,_)` to ``[Large]Utf8`. Co-authored-by: Sumit <[email protected]>
ovr
pushed a commit
to cube-js/arrow-rs
that referenced
this pull request
Aug 25, 2022
…e#698) the change adds uses the existing `PrimitiveArray::value_as_datetime` to support casting from `Timestamp(_,_)` to ``[Large]Utf8`. Co-authored-by: Sumit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic cherry-pick of f569e8f