Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick of Support binary data type in build_struct_array #705

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 21, 2021

Manual cherry-pick of 8308615

* Support binary data type in `build_struct_array`.

* Modify test case.

* cargo fmt

Co-authored-by: Andrew Lamb <[email protected]>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2021

Codecov Report

Merging #705 (918cf21) into active_release (412a5bd) will increase coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@               Coverage Diff               @@
##           active_release     #705   +/-   ##
===============================================
  Coverage           82.41%   82.42%           
===============================================
  Files                 167      167           
  Lines               46618    46640   +22     
===============================================
+ Hits                38421    38441   +20     
- Misses               8197     8199    +2     
Impacted Files Coverage Δ
arrow/src/json/reader.rs 83.85% <90.90%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412a5bd...918cf21. Read the comment docs.

@alamb alamb merged commit 4ca0d95 into active_release Aug 23, 2021
@alamb alamb deleted the cherry_pick_8308615d branch August 26, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants