fix: NullBufferBuilder::allocated_size should return Size in Bytes #7122
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7121.
Rationale for this change
Refer to the comment from @tustvold in issue#7121
"Given no reasonable allocator allocates memory in bits, it is somewhat expected that the quantity returned is in bytes, and returning in bits is a bug."
What changes are included in this PR?
Updates the
NullBufferBuilder::allocated_size
function to return the size in bytes.Are there any user-facing changes?
This change will break public API usage of
NullBufferBuilder::allocated_size
: