GH-38907: [C++] Stop installing internal bpacking_simd* headers (#38908)

### Rationale for this change They are for internal use. We don't need to install them. ### What changes are included in this PR? Use `_internal.h` suffix to avoid installing them. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #38907 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
apache · Nov 29, 2023 · 9aff60a · 9aff60a
1 parent 6f497ec
commit 9aff60a
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 9 deletions.
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -2388,10 +2388,10 @@ if(ARROW_USE_XSIMD)
   resolve_dependency(xsimd
                      FORCE_ANY_NEWER_VERSION
                      TRUE
+                     IS_RUNTIME_DEPENDENCY
+                     FALSE
                      REQUIRED_VERSION
-                     "8.1.0"
-                     PC_PACKAGE_NAMES
-                     xsimd)
+                     "8.1.0")
 
   if(xsimd_SOURCE STREQUAL "BUNDLED")
     add_library(arrow::xsimd INTERFACE IMPORTED)

diff --git a/cpp/src/arrow/util/bpacking_avx2.cc b/cpp/src/arrow/util/bpacking_avx2.cc
@@ -16,7 +16,7 @@
 // under the License.
 
 #include "arrow/util/bpacking_avx2.h"
-#include "arrow/util/bpacking_simd256_generated.h"
+#include "arrow/util/bpacking_simd256_generated_internal.h"
 #include "arrow/util/bpacking_simd_internal.h"
 
 namespace arrow {

diff --git a/cpp/src/arrow/util/bpacking_avx512.cc b/cpp/src/arrow/util/bpacking_avx512.cc
@@ -16,7 +16,7 @@
 // under the License.
 
 #include "arrow/util/bpacking_avx512.h"
-#include "arrow/util/bpacking_simd512_generated.h"
+#include "arrow/util/bpacking_simd512_generated_internal.h"
 #include "arrow/util/bpacking_simd_internal.h"
 
 namespace arrow {

diff --git a/cpp/src/arrow/util/bpacking_neon.cc b/cpp/src/arrow/util/bpacking_neon.cc
@@ -16,7 +16,7 @@
 // under the License.
 
 #include "arrow/util/bpacking_neon.h"
-#include "arrow/util/bpacking_simd128_generated.h"
+#include "arrow/util/bpacking_simd128_generated_internal.h"
 #include "arrow/util/bpacking_simd_internal.h"
 
 namespace arrow {

diff --git a/...c/arrow/util/bpacking_simd128_generated.h → ...til/bpacking_simd128_generated_internal.h b/...c/arrow/util/bpacking_simd128_generated.h → ...til/bpacking_simd128_generated_internal.h
diff --git a/...c/arrow/util/bpacking_simd256_generated.h → ...til/bpacking_simd256_generated_internal.h b/...c/arrow/util/bpacking_simd256_generated.h → ...til/bpacking_simd256_generated_internal.h
diff --git a/...c/arrow/util/bpacking_simd512_generated.h → ...til/bpacking_simd512_generated_internal.h b/...c/arrow/util/bpacking_simd512_generated.h → ...til/bpacking_simd512_generated_internal.h
diff --git a/cpp/src/arrow/util/bpacking_simd_codegen.py b/cpp/src/arrow/util/bpacking_simd_codegen.py
@@ -18,9 +18,9 @@
 # under the License.
 
 # Usage:
-#   python bpacking_simd_codegen.py 128 > bpacking_simd128_generated.h
-#   python bpacking_simd_codegen.py 256 > bpacking_simd256_generated.h
-#   python bpacking_simd_codegen.py 512 > bpacking_simd512_generated.h
+#   python bpacking_simd_codegen.py 128 > bpacking_simd128_generated_internal.h
+#   python bpacking_simd_codegen.py 256 > bpacking_simd256_generated_internal.h
+#   python bpacking_simd_codegen.py 512 > bpacking_simd512_generated_internal.h
 
 from functools import partial
 import sys