Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Gandiva] LLVM JIT upgrade causing test and build failures #45132

Closed
lriggs opened this issue Dec 30, 2024 · 1 comment
Closed

[C++][Gandiva] LLVM JIT upgrade causing test and build failures #45132

lriggs opened this issue Dec 30, 2024 · 1 comment
Assignees
@lriggs
Labels
Component: C++ Component: Gandiva Type: bug
Milestone
20.0.0

Comments

@lriggs
Copy link
Contributor

lriggs commented Dec 30, 2024

Describe the bug, including details regarding any error messages, version, and platform.

#37848 upgraded the JIT compiler for LLVM/Gandiva code which presented linking errors with newer version of LLVM. Some Gandiva tests were disabled, and here at Dremio I am running into the same linking problem when trying to build with an updated Arrow library. LLVM devs are aware of the linking problem, which seems to be an issue with the package exports, but there is no fix yet. In the meantime I'm proposing reverting the JIT upgrade since it was a maintenance item and not strictly necessary at this time.

More discussion in apache/arrow-java#63.

Component(s)

C++, Gandiva
@lriggs lriggs mentioned this issue Dec 30, 2024
Merged
@kou kou changed the title [C++] LLVM JIT upgrade causing test and build failures. [C++][Gandiva] LLVM JIT upgrade causing test and build failures Dec 31, 2024
lriggs added a commit to lriggs/arrow that referenced this issue Jan 24, 2025
@lriggs
apacheGH-45132 Upgrade LLVM to 18.1 which fixes the unexported orc sy…
e77fae5 
…mbol issu.
lriggs added a commit to lriggs/arrow that referenced this issue Jan 30, 2025
@lriggs
apacheGH-45132 Upgrade LLVM to 18.1 which fixes the unexported orc sy…
6b904e4 
…mbol issu.
kou pushed a commit that referenced this issue Feb 3, 2025
@lriggs
GH-45132: [C++][Gandiva] Update LLVM to 18.1 (#45114)
31747f0 
### Rationale for this change
#37848 upgraded the JIT compiler for LLVM/Gandiva code which presented linking errors with newer version of LLVM. Some Gandiva tests were disabled, and here at Dremio I am running into the same linking problem when trying to build with an updated Arrow library. After reading some threads on the LLVM discord server it appears that updating to LLVM 18.1 will fix the symbol issue. I tested locally and was able to re-enable the disabled java tests which were showing the unexported ORC symbol issue.

More discussion in apache/arrow-java#63.

### What changes are included in this PR?
Updating vcpkg and pinning LLVM to 18.1 Notably I found encountered some build problems using the newest vcpkg update, which appeared to be related to the updated gRPC libraries. My Arrow jar CI build was timing out in this case with no clear error in the logs. The vcpkg version included here has the LLVM 18 update but not the gRPC update (which isn't needed for this issue).

### Are these changes tested?
Covered by existing tests. Will also re-enable the disabled Java tests in a future change.

### Are there any user-facing changes?
No.

* GitHub Issue: #45132

Lead-authored-by: Logan Riggs <[email protected]>
Co-authored-by: lriggs <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 20.0.0 milestone Feb 3, 2025
@kou
Copy link
Member

kou commented Feb 3, 2025

Issue resolved by pull request 45114
#45114

@kou kou closed this as completed Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lriggs lriggs

Labels
Component: C++ Component: Gandiva Type: bug
Projects
None yet
Milestone
20.0.0
Development

No branches or pull requests
2 participants
@kou @lriggs