You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CMake Warning at /usr/local/share/cmake-3.29/Modules/FindBoost.cmake:1398 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
/usr/local/share/cmake-3.29/Modules/FindBoost.cmake:1523 (_Boost_COMPONENT_DEPENDENCIES)
/usr/local/share/cmake-3.29/Modules/FindBoost.cmake:2135 (_Boost_MISSING_DEPENDENCIES)
cmake_modules/ThirdpartyToolchain.cmake:313 (find_package)
cmake_modules/ThirdpartyToolchain.cmake:1292 (resolve_dependency)
CMakeLists.txt:546 (include)
…OW_BUILD_SHARED=OFF (#45424)
### Rationale for this change
We can use `libarrow_testing.a` without `boost::filesystem` when `arrow::util::Process` isn't used.
### What changes are included in this PR?
`ARROW_TESTING=ON` requires Boost. If `ARROW_BUILD_SHARED=ON` is also used, Boost libraries are also required.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* GitHub Issue: #45423
Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Describe the bug, including details regarding any error messages, version, and platform.
https://github.com/ursacomputing/crossbow/actions/runs/13125731106/job/36621579172#step:7:271
This happened after #45397 is merged.
In general,
libarrow_testing.{a,so}
that are also used by fuzzer requireboost::filesystem
becausearrow::util::Process
uses it:arrow/cpp/src/arrow/testing/process.cc
Lines 76 to 92 in 1567be0
But it seems that we can use
libarrow_testing.a
withoutboost::filesystem
when we don't usearrow::util::Process
.test-build-cpp-fuzz
prepare only Boost headers: https://github.com/google/oss-fuzz/blob/e007cb7be3868cb4f55e030c6c2a4199ca750bb6/projects/arrow/build.sh#L20-L28So, let's require
boost::filesystem
only whenlibarrow_testing.so
is used.Component(s)
C++, Continuous Integration
The text was updated successfully, but these errors were encountered: