Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-18264: [Python] Add missing value accessor to temporal types #14746

Conversation

0x26res
Copy link
Contributor

@0x26res 0x26res commented Nov 27, 2022

No description provided.

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@0x26res 0x26res changed the title Add missing value accessor to logical types ARROW-18264: [Python] Add missing value accessor to logical types Nov 27, 2022
@github-actions
Copy link

@pitrou pitrou changed the title ARROW-18264: [Python] Add missing value accessor to logical types ARROW-18264: [Python] Add missing value accessor to temporal types Dec 5, 2022
@pitrou
Copy link
Member

pitrou commented Dec 5, 2022

@jorisvandenbossche Do you want to comment on this?

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jorisvandenbossche jorisvandenbossche merged commit 84101a5 into apache:master Dec 13, 2022
@jorisvandenbossche jorisvandenbossche added this to the 11.0.0 milestone Dec 13, 2022
@0x26res
Copy link
Contributor Author

0x26res commented Dec 13, 2022

@jorisvandenbossche @pitrou thanks for reviewing 👍

@ursabot
Copy link

ursabot commented Dec 14, 2022

Benchmark runs are scheduled for baseline = 9753a67 and contender = 84101a5. 84101a5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.5% ⬆️0.0%] test-mac-arm
[Finished ⬇️1.9% ⬆️1.63%] ursa-i9-9960x
[Finished ⬇️3.99% ⬆️1.96%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 84101a55 ec2-t3-xlarge-us-east-2
[Finished] 84101a55 test-mac-arm
[Finished] 84101a55 ursa-i9-9960x
[Finished] 84101a55 ursa-thinkcentre-m75q
[Finished] 9753a672 ec2-t3-xlarge-us-east-2
[Finished] 9753a672 test-mac-arm
[Finished] 9753a672 ursa-i9-9960x
[Finished] 9753a672 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants