ARROW-4340: [C++][CI] Build IWYU for LLVM 7 in iwyu docker-compose job #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I3bf8bd27728094656e81af480de607853259c694
kszucs
reviewed
Feb 14, 2019
dev/lint/run_iwyu.sh
Outdated
|
|
||
| popd | ||
|
|
||
| # Build IWYU for current Clang |
There was a problem hiding this comment.
This should go into the image instead of building it on each docker-compose run iwyu.
Please factor out into a scripts, e.g. ci/docker_install_iwyu.sh and build iwyu in its Dockerfile similarly like We install conda.
|
+1. I tested this locally. This isn't run in CI and the linter passed so I'll merge see output here https://gist.github.com/wesm/d3ea882af3b64b43a31ae1b2d2602877 |
tanyaschlusser
pushed a commit
to tanyaschlusser/arrow
that referenced
this pull request
Feb 21, 2019
Following the instructions in docker-compose.yml gives me a working IWYU build now ``` export PYTHON_VERSION=3.6 docker-compose build cpp docker-compose build python docker-compose build lint docker-compose run iwyu ``` Author: François Saint-Jacques <[email protected]> Author: Wes McKinney <[email protected]> Closes apache#3643 from wesm/ARROW-4340 and squashes the following commits: 56733fc <François Saint-Jacques> Refactor iwyu build into docker install script. (apache#8) e1c46c7 <Wes McKinney> Build IWYU for LLVM 7 in iwyu docker-compose job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the instructions in docker-compose.yml gives me a working IWYU build now