Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Python] Remove spurious dot in docstring #38588

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

ChinYikMing
Copy link
Contributor

The signature of function to finalize output stream is getvalue instead of get.value.

Copy link

github-actions bot commented Nov 4, 2023

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@ChinYikMing ChinYikMing changed the title [Python][Docs] PyArrow Documentation remove the unnecessary dot to avoid confusion MINOR: [Python][Docs] PyArrow Documentation remove the unnecessary dot to avoid confusion Nov 6, 2023
@pitrou pitrou changed the title MINOR: [Python][Docs] PyArrow Documentation remove the unnecessary dot to avoid confusion MINOR: [Python] Remove spurious dot in docstring Nov 29, 2023
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this @ChinYikMing .

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Nov 29, 2023
@pitrou
Copy link
Member

pitrou commented Nov 29, 2023

CI failure looks unrelated.

@pitrou pitrou merged commit 0940fec into apache:main Nov 29, 2023
9 of 10 checks passed
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Nov 29, 2023
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 0940fec.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
The signature of function to finalize output stream is `getvalue` instead of `get.value`.

Authored-by: ChinYikMing <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants