Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Python] Fix name of new keyword in the concat_tables future warning #38710

Merged

Conversation

jorisvandenbossche
Copy link
Member

We renamed the new keyword in a final iteration of the PR, but apparently forgot to update the warning message.

@jorisvandenbossche jorisvandenbossche merged commit cd0d7f5 into apache:main Nov 14, 2023
@jorisvandenbossche jorisvandenbossche removed the awaiting committer review Awaiting committer review label Nov 14, 2023
@jorisvandenbossche jorisvandenbossche deleted the minor-concat_tables-msg branch November 14, 2023 16:31
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit cd0d7f5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…arning (apache#38710)

We renamed the new keyword in a final iteration of the PR, but apparently forgot to update the warning message.

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants