Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-41124: [CI][C++] Don't use CMake 3.29.1 with vcpkg #41151

Merged
merged 14 commits into from
Apr 12, 2024
Merged

GH-41124: [CI][C++] Don't use CMake 3.29.1 with vcpkg #41151

merged 14 commits into from
Apr 12, 2024

Conversation

kou
Copy link
Member

@kou kou commented Apr 11, 2024 •
edited by github-actions bot
Loading

Rationale for this change

vcpkg doesn't work with CMake 3.29.1.

See also: microsoft/vcpkg#37968

What changes are included in this PR?

Use CMake 3.29.0 temporary.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou kou requested review from assignUser and raulcd as code owners April 11, 2024 13:07
@kou
Copy link
Member Author

kou commented Apr 11, 2024

@github-actions crossbow submit test-build-vcpkg-win

@github-actions GitHub Actions
Copy link

⚠️ GitHub issue #41124 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Apr 11, 2024
@github-actions GitHub Actions
Copy link 

Failed to render template `vcpkg-tests/github.windows.yml` with UndefinedError: 'macros' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/8647244016

@kou kou force-pushed the ci-cmake-3.29.1 branch from df2a078 to 7c710e2 Compare April 11, 2024 13:13
@kou
Copy link
Member Author

kou commented Apr 11, 2024

@github-actions crossbow submit test-build-vcpkg-win

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Apr 11, 2024

@github-actions crossbow submit test-build-vcpkg-win wheel-macos-big-sur-cp310-arm64 wheel-macos-catalina-cp310-amd64

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Apr 11, 2024

@github-actions crossbow submit test-build-vcpkg-win wheel-macos-big-sur-cp310-arm64 wheel-macos-catalina-cp310-amd64

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Apr 11, 2024

@github-actions crossbow submit test-build-vcpkg-win wheel-macos-big-sur-cp310-arm64 wheel-macos-catalina-cp310-amd64

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Apr 11, 2024

@github-actions crossbow submit test-build-vcpkg-win wheel-macos-big-sur-cp310-arm64 wheel-macos-catalina-cp310-amd64

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Apr 11, 2024

@github-actions crossbow submit wheel-macos-big-sur-cp310-arm64 wheel-macos-catalina-cp310-amd64

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Apr 11, 2024

@github-actions crossbow submit test-build-vcpkg-win wheel-macos-big-sur-cp310-arm64 wheel-macos-catalina-cp310-amd64

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Apr 11, 2024

@github-actions crossbow submit wheel-macos-big-sur-cp310-arm64 wheel-macos-catalina-cp310-amd64

@kou
Copy link
Member Author

kou commented Apr 11, 2024

@github-actions crossbow submit wheel-macos-big-sur-cp310-arm64

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Apr 12, 2024

@github-actions crossbow submit wheel-macos-big-sur-cp310-arm64

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
assignUser
assignUser approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green

dev/tasks/python-wheels/github.osx.yml Outdated Show resolved Hide resolved
@kou @assignUser
Fix a typo
d46405f 
Co-authored-by: Jacob Wujciak-Jens <[email protected]>
@kou
Copy link
Member Author

kou commented Apr 12, 2024

@github-actions crossbow submit test-build-vcpkg-win wheel-macos-*

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Apr 12, 2024
@github-actions GitHub Actions
Copy link

Revision: d46405f

Submitted crossbow builds: ursacomputing/crossbow @ actions-725c44d5be

Task Status
test-build-vcpkg-win GitHub Actions
wheel-macos-big-sur-cp310-arm64 GitHub Actions
wheel-macos-big-sur-cp311-arm64 GitHub Actions
wheel-macos-big-sur-cp312-arm64 GitHub Actions
wheel-macos-big-sur-cp38-arm64 GitHub Actions
wheel-macos-big-sur-cp39-arm64 GitHub Actions
wheel-macos-catalina-cp310-amd64 GitHub Actions
wheel-macos-catalina-cp311-amd64 GitHub Actions
wheel-macos-catalina-cp312-amd64 GitHub Actions
wheel-macos-catalina-cp38-amd64 GitHub Actions
wheel-macos-catalina-cp39-amd64 GitHub Actions

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 12, 2024
@kou
Copy link
Member Author

kou commented Apr 12, 2024

@github-actions crossbow submit wheel-manylinux-2-28-cp310-* wheel-windows-cp310-*

@github-actions GitHub Actions
Copy link

Revision: 56eb753

Submitted crossbow builds: ursacomputing/crossbow @ actions-7a9aae0078

Task Status
wheel-manylinux-2-28-cp310-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-arm64 GitHub Actions
wheel-windows-cp310-amd64 GitHub Actions

@kou
Copy link
Member Author

kou commented Apr 12, 2024

+1

@kou kou merged commit 92c4948 into apache:main Apr 12, 2024
12 checks passed
@kou kou deleted the ci-cmake-3.29.1 branch April 12, 2024 05:15
@kou kou removed the awaiting change review Awaiting change review label Apr 12, 2024
@kou kou mentioned this pull request Apr 12, 2024
Closed
raulcd pushed a commit that referenced this pull request Apr 12, 2024
@kou @assignUser @raulcd
GH-41124: [CI][C++] Don't use CMake 3.29.1 with vcpkg (#41151)
9bdf082 
### Rationale for this change

vcpkg doesn't work with CMake 3.29.1.

See also: microsoft/vcpkg#37968

### What changes are included in this PR?

Use CMake 3.29.0 temporary.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #41124

Lead-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@conbench-apache-arrow conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 92c4948.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 20 possible false positives for unstable benchmarks that are known to sometimes produce them.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request Apr 15, 2024
@kou @assignUser @vibhatha
apacheGH-41124: [CI][C++] Don't use CMake 3.29.1 with vcpkg (apache#4…
fb704a1 
…1151)

### Rationale for this change

vcpkg doesn't work with CMake 3.29.1.

See also: microsoft/vcpkg#37968

### What changes are included in this PR?

Use CMake 3.29.0 temporary.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41124

Lead-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
@kou @assignUser @tolleybot
apacheGH-41124: [CI][C++] Don't use CMake 3.29.1 with vcpkg (apache#4…
e69df47 
…1151)

### Rationale for this change

vcpkg doesn't work with CMake 3.29.1.

See also: microsoft/vcpkg#37968

### What changes are included in this PR?

Use CMake 3.29.0 temporary.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41124

Lead-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
tolleybot pushed a commit to tmct/arrow that referenced this pull request May 4, 2024
@kou @assignUser @tolleybot
apacheGH-41124: [CI][C++] Don't use CMake 3.29.1 with vcpkg (apache#4…
6dd43e9 
…1151)

### Rationale for this change

vcpkg doesn't work with CMake 3.29.1.

See also: microsoft/vcpkg#37968

### What changes are included in this PR?

Use CMake 3.29.0 temporary.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41124

Lead-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
rok pushed a commit to tmct/arrow that referenced this pull request May 8, 2024
@kou @assignUser @rok
apacheGH-41124: [CI][C++] Don't use CMake 3.29.1 with vcpkg (apache#4…
3c44352 
…1151)

### Rationale for this change

vcpkg doesn't work with CMake 3.29.1.

See also: microsoft/vcpkg#37968

### What changes are included in this PR?

Use CMake 3.29.0 temporary.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41124

Lead-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
rok pushed a commit to tmct/arrow that referenced this pull request May 8, 2024
@kou @assignUser @rok
apacheGH-41124: [CI][C++] Don't use CMake 3.29.1 with vcpkg (apache#4…
3502695 
…1151)

### Rationale for this change

vcpkg doesn't work with CMake 3.29.1.

See also: microsoft/vcpkg#37968

### What changes are included in this PR?

Use CMake 3.29.0 temporary.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41124

Lead-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
@kou @assignUser @vibhatha
apacheGH-41124: [CI][C++] Don't use CMake 3.29.1 with vcpkg (apache#4…
0f8f182 
…1151)

### Rationale for this change

vcpkg doesn't work with CMake 3.29.1.

See also: microsoft/vcpkg#37968

### What changes are included in this PR?

Use CMake 3.29.0 temporary.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41124

Lead-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser assignUser approved these changes

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kou @assignUser