ARROW-1135: [C++] Use clang 4.0 in one of the Linux builds #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sweet, +1 |
Change-Id: I01c7577d951f618b971f2fe4d8a2486e144364a0
Change-Id: I3091876173be9c2d0fd038dff4b800261845a526
Change-Id: I845659a3a46ce57ef59b5676bc078831d9892db2
Change-Id: I7fcaf4cc859e24cc344ade83b571b66c9741e7a2
|
While working on this I discovered we were indicating externalproject dependencies incorrectly, but I think it's fixed now (created a synthetic target to capture all of the build pre-requisites for the arrow library) |
|
+1. I'm not sure why the Travis CI build didn't run, but it ran on my fork: https://travis-ci.org/wesm/arrow/builds/246412973 |
wesm
commented
Jun 24, 2017
| if(FLATBUFFERS_VENDORED) | ||
| set(ARROW_DEPENDENCIES ${ARROW_DEPENDENCIES} flatbuffers_ep) |
There was a problem hiding this comment.
For future reference, this way of declaring dependencies as a list with EP's seems to not work with all versions of CMake. It works with library targets though for some reason
pitrou
pushed a commit
that referenced
this pull request
Jan 4, 2022
…test for rust arrow-rs has added `MONTH_DAY_NANO` interval type in PR [#779](apache/arrow-rs#779), we need to enable integration tests for it. Closes #11238 from b41sh/rust-month_day_nano_interval Lead-authored-by: b41sh <[email protected]> Co-authored-by: baishen <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help us keep the Linux build clean on latest clang