ARROW-10756: [Rust][DataFusion] Fix reduntant clones #8791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Daniël, I'm looking into what we can change in our CI to avoid running out of disk space. I'll try fix that today. Given that CI isn't cheap (as we now see from Travis), it's not always possible to rerun CI before merging PRs, to check if they break anything merged before them. |
nevi-me
approved these changes
Nov 28, 2020
|
CI failure is not because of tests, so I'm merging this |
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
This fixes the CI. Was introduced in apache#8688 , I guess because the CI there ran before the merge. Closes apache#8791 from Dandandan/fix_clone Authored-by: Heres, Daniel <[email protected]> Signed-off-by: Neville Dipale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the CI.
Was introduced in #8688 , I guess because the CI there ran before the merge.