-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-11074: [Rust][DataFusion] Implement predicate push-down for parquet tables #9064
Closed
yordan-pavlov
wants to merge
18
commits into
apache:master
from
yordan-pavlov:parquet_predicate_push_down
Closed
Changes from 10 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a646088
implement predicate push-down for parquet tables
yordan-pavlov 0f28e8d
fix rustfmt issues
yordan-pavlov b00daec
fix clippy issues
yordan-pavlov bbaf809
fix array_reader tests, broken with previous change
yordan-pavlov 5b2b6f2
rebase onto master and fix MutableBuffer.freeze() warning
yordan-pavlov a03ccf9
add test for no pages case for ComplexObjectArrayReader
yordan-pavlov 2e78552
implement Copy trait for StatisticsType
yordan-pavlov 5db2c6f
implement Copy trait for Operator
yordan-pavlov 3f619d8
add tests for combine_filters function
yordan-pavlov d1af10d
Merge 'upstream/master' into parquet_predicate_push_down
yordan-pavlov 5d7dda7
refactor StatisticsExpressionBuilder and add tests for build_predicat…
yordan-pavlov 61f5656
add more tests for build_statistics_array and RowGroupPredicateBuilder
yordan-pavlov 30d6d7d
add test for NullArray::new_with_type
yordan-pavlov 750b8a2
add test for SerializedFileReader::filter_row_groups
yordan-pavlov 0f4e18e
add more comments to better explain how parquet predicate push-down w…
yordan-pavlov 6e0f409
fix clippy warnings
yordan-pavlov 2de3d6c
Merge remote-tracking branch 'upstream/master' into parquet_predicate…
yordan-pavlov bd22f64
fix clippy errors in tests
yordan-pavlov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, I feel we should have a proper filter API defined in data fusion which can be shared among various data sources. On the other hand, the actual filtering logic should be implemented by different data sources / formats, probably via converting the data fusion's filter API to the corresponding ones from the latter.
But this is a very good start and we can probably do them as follow ups (if we don't care much for API changes).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that starting with this PR and then extending the approach to be something more generic is a good approach.