ARROW-11542: [Rust] fix validity bitmap buffer length count in json reader #9436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9436 +/- ##
==========================================
+ Coverage 82.14% 82.17% +0.02%
==========================================
Files 232 232
Lines 54150 54177 +27
==========================================
+ Hits 44484 44520 +36
+ Misses 9666 9657 -9
Continue to review full report at Codecov.
|
alamb
approved these changes
Feb 9, 2021
There was a problem hiding this comment.
Thanks @houqp -- looks good.
For anyone else who is curious, the new test fails like this without the code change:
failures:
---- json::reader::tests::test_json_read_list_of_structs stdout ----
thread 'json::reader::tests::test_json_read_list_of_structs' panicked at 'index out of bounds: the len is 1 but the index is 1', arrow/src/util/bit_util.rs:68:5
failures:
json::reader::tests::test_json_read_list_of_structs
nevi-me
pushed a commit
to nevi-me/arrow
that referenced
this pull request
Feb 13, 2021
…eader Closes apache#9436 from houqp/qp_json_read Authored-by: Qingping Hou <[email protected]> Signed-off-by: Andrew Lamb <[email protected]>
sgnkc
pushed a commit
to sgnkc/arrow
that referenced
this pull request
Feb 17, 2021
…eader Closes apache#9436 from houqp/qp_json_read Authored-by: Qingping Hou <[email protected]> Signed-off-by: Andrew Lamb <[email protected]>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
…eader Closes apache#9436 from houqp/qp_json_read Authored-by: Qingping Hou <[email protected]> Signed-off-by: Andrew Lamb <[email protected]>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
…eader Closes apache#9436 from houqp/qp_json_read Authored-by: Qingping Hou <[email protected]> Signed-off-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.