AVRO-3851: [Rust] Validate default value for record fields and enums on parsing #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarutak
changed the title
martin-g
approved these changes
Sep 7, 2023
martin-g
pushed a commit
that referenced
this pull request
Sep 7, 2023
…on parsing (#2481) (cherry picked from commit 2244da0) Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
|
Thank you, @sarutak ! |
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVRO-3851
What is the purpose of the change
This PR proposes to improve the functionality of parsing default values for record fields and enums.
Currently, default values for record fields are validated on parsing only if their types are
union.It's nice to apply such validation for other types.
Similarly, default values for
enumare not also validated on parsing now.So this PR changes parser functionality to validate default values for record fields and enums.
Verifying this change
Added new tests.
Documentation