-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lang/rust: Migrate to avro-rs #3199
Conversation
<exclude>lang/rust/Cargo.lock</exclude> | ||
<exclude>lang/rust/README.tpl</exclude> | ||
<exclude>lang/rust/.requirements-precommit.txt</exclude> | ||
<exclude>lang/rust/README.md</exclude> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Xuanwo What do you use instead of RAT for license checking in your projects ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm using https://github.com/korandoru/hawkeye which written in rust and provides github actions natively:
licenses:
runs-on: ubuntu-latest
timeout-minutes: 10
env:
FORCE_COLOR: 1
steps:
- uses: actions/checkout@v4
- name: Check license headers
uses: korandoru/hawkeye@v5
lang/rust/README.md
Outdated
## WebAssembly demo application | ||
|
||
See [wasm-demo/README.md](./wasm-demo/README.md) | ||
We apologize for the inconvenience and greatly appreciate your contributions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, why only rust version moved to its own repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an experiment, if it ends up being better for sustained development, the other languages will likely be split out as well.
It seems the Python tests depend on the Rust toolchain. |
Linking to the dev mailing list thread where the rationale was explained: |
Thank you for the suggestion; it's been added to the Rust README now. |
Thank you, @Xuanwo ! |
Some python tools are written in rust:
I'm working on this now. |
Oh, they have been failing for a long time, even before this PR. |
I see that Tracked at milesgranger/cramjam#185 |
What is the purpose of the change
This PR migrates the rust codebase to avro-rs
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.