Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVRO-4096: [C++] Replace boost::optional with std::optional #3254

Merged
merged 1 commit into from
Dec 6, 2024
Merged

AVRO-4096: [C++] Replace boost::optional with std::optional #3254

merged 1 commit into from
Dec 6, 2024

Conversation

wgtmac
Copy link
Member

@wgtmac wgtmac commented Dec 6, 2024

What is the purpose of the change

This is part of an effort to remove boost dependency as much as possible and replace it with standard library.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@github-actions github-actions bot added the C++ Pull Requests for C++ binding label Dec 6, 2024
@wgtmac
Copy link
Member Author

wgtmac commented Dec 6, 2024

cc @martin-g

Fokko
Fokko approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @wgtmac

@Fokko Fokko merged commit 77540f6 into apache:main Dec 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

@martin-g martin-g martin-g approved these changes

Assignees
No one assigned
Labels
C++ Pull Requests for C++ binding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wgtmac @martin-g @Fokko