AVRO-4097: Replace boost::any with std::any; boost::tuple with std::tuple #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Mikhail Koviazin <[email protected]>
martin-g
approved these changes
Dec 6, 2024
|
cc @wgtmac |
|
Thank you, @mkmkme ! |
|
The reason that boost tuple, boost any etc were being used is that not every compiler env has the ones in the standard. I added a command line option to tell the code generator that one is using the cpp17 dialect, which does have them. |
|
c++17 is required by default by avro-cpp though: https://github.com/apache/avro/blob/main/lang/c%2B%2B/CMakeLists.txt#L24 And C++17 features were supported by gcc7 and clang4, the latest of them was released in 2018. So we should be safe here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request reduces the usage of boost by replacing
boost::anyandboost::tuplewithstd::anyandstd::tuplerespectively, fixing AVRO-4097Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation