Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website][adhoc] Fix spellcheck errors and typos #23575

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

aromanenko-dev
Copy link
Contributor

Fix spellcheck errors and typos found with cspell tool


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@aromanenko-dev
Copy link
Contributor Author

R: @kennknowles
R: @pabloem

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I'm surprised! especially the ones that were formal identifiers or the ones that impacted rendering or functionality.

@@ -70,7 +70,7 @@ pipeline
`HCatalogIO` is built for Apache HCatalog versions 2 and up and will not work out of the box for older versions of HCatalog.
The following illustrates a workaround to work with Hive 1.1.

Include the following Hive 1.2 jars in the über jar you build.
Include the following Hive 1.2 jars in the uber jar you build.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was correct before, no? I don't know :-)

Copy link
Contributor Author

@aromanenko-dev aromanenko-dev Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, yes, it comes from a German word with "ü" as the first character, whereas, iinm, in English we don't have such one. So, actually, the both are correct but I thought that for English version we should stick with just English alphabet.

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Oct 12, 2022

@kennknowles

the ones that impacted rendering or functionality.

Actually, that was an initial reason why I decided to check the whole documentation for errors/typos.

@aromanenko-dev aromanenko-dev merged commit 1c1ecb2 into apache:master Oct 12, 2022
@aromanenko-dev aromanenko-dev deleted the website-spellcheck branch October 12, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants