Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparison warning in http2_rpc_protocol.cpp #2626

Merged
merged 1 commit into from
May 6, 2024
Merged

Fix comparison warning in http2_rpc_protocol.cpp #2626

merged 1 commit into from
May 6, 2024

Conversation

imdouyu
Copy link
Contributor

@imdouyu imdouyu commented Apr 29, 2024

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

chenBright
chenBright reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@chenBright chenBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imdouyu imdouyu closed this May 1, 2024
@imdouyu imdouyu reopened this May 1, 2024
@wwbmmm wwbmmm merged commit edb9caf into apache:master May 6, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenBright chenBright chenBright left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imdouyu @chenBright @wwbmmm