UI improvements #9773

abh1sar · 2024-10-06T15:34:28Z

Description

This PR does multiple UI improvements

Autofill vCenter host, datacenter and credentials while adding cluster using the zone wide value from vmware_data_center table
Show Usage settings as a different pane in global settings
Option to attach the volume to an instance during volume create.
Show mgmt server's service ip in the details tab of Infrastructure -> Management server.
Don't display create volume snapshot button in the Instance tab for KVM, if the instance is running and "kvm.snapshot.enabled" is false. (Also contains some code cleanup in storage.js)
The name Recurring snapshots is used everywhere except for one place where 'Scheduled' snapshots is used in the Recurring Snapshots form. Change it to Recurring Snapshots.
Reorder the Hypervisor list shown everywhere in order of popularity.

Items 1,3,4,5,6 are UI only changes, and can be tested with just the UI.

Doc PR : apache/cloudstack-documentation#448

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

… than English (apache#9766) * Fix updateTemplatePermission UI in non-english language * Improve fix --------- Co-authored-by: Lucas Martins <[email protected]>

…l-snapshots

codecov · 2024-10-06T15:41:49Z

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 16.03%. Comparing base (ac19379) to head (92a3dcd).

Files with missing lines	Patch %	Lines
...udstack/api/response/ManagementServerResponse.java	0.00%	4 Missing ⚠️
...a/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java	0.00%	4 Missing ⚠️
...com/cloud/network/vpn/Site2SiteVpnManagerImpl.java	0.00%	2 Missing ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20    #9773      +/-   ##
============================================
- Coverage     16.03%   16.03%   -0.01%     
  Complexity    12814    12814              
============================================
  Files          5637     5637              
  Lines        493507   493552      +45     
  Branches      59831    59842      +11     
============================================
- Hits          79131    79130       -1     
- Misses       405600   405646      +46     
  Partials       8776     8776

Flag	Coverage Δ
uitests	`4.01% <ø> (-0.01%)`	⬇️
unittests	`16.87% <8.33%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

abh1sar · 2024-10-06T18:22:34Z

@blueorangutan package

blueorangutan · 2024-10-06T18:24:03Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-10-06T19:30:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11289

abh1sar · 2024-10-07T03:59:56Z

@blueorangutan ui

blueorangutan · 2024-10-07T04:01:03Z

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-10-07T04:17:49Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9773 (QA-JID-461)

DaanHoogland · 2024-10-07T13:39:09Z

@abh1sar , given that there are DB changes as well, I don't think UI tests will be enought, do you?

abh1sar · 2024-10-08T01:23:22Z

@abh1sar , given that there are DB changes as well, I don't think UI tests will be enought, do you?

@DaanHoogland You are right.
These items contain db changes for which full testing will be required
2. Show Usage settings as a different pane in global settings
7. Reorder the Hypervisor list shown everywhere in order of popularity.

For the rest of the items, ui testing is enough.

P.S I have added db changes to schema-41900to42000 for now. Will move it to schema-42000-42010 once CloudStack version changes to 4.20.1. Will keep this PR in draft until then.

rohityadavcloud · 2024-10-08T09:11:12Z

engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql

@@ -425,3 +425,8 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervi

 CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.vm_instance', 'delete_protection', 'boolean DEFAULT FALSE COMMENT "delete protection for vm" ');
 CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.volumes', 'delete_protection', 'boolean DEFAULT FALSE COMMENT "delete protection for volumes" ');
+
+-- Create a new group for Usage Server related configurations
+INSERT INTO `cloud`.`configuration_group` (`name`, `description`, `precedence`) VALUES ('Usage Server', 'Usage Server related configuration', 9);


cc @sureshanaparti to check if configkeys can be self-discovered without any schema paths? Otherwise, we may need to move this to a new 4.20.0->4.20.1 upgrade path.

ping @sureshanaparti

yes, the config keys will be discover group and sub-group if they doesn't have (so, mostly for the new configs added after this new group & subgroup). If the config keys already have (all existing configs) and need to be re-discover to this, then schema path needs to remove group and sub-group for the configs Or update configs with group and sub-group ids with the new group and sub-group ids added here.

cc @abh1sar @borisstoyanov @rohityadavcloud

Pearl1594

clgtm, just a few queries.

Pearl1594 · 2024-10-10T01:02:12Z

ui/src/config/section/compute.js

-            return ((['Running'].includes(record.state) && record.hypervisor !== 'LXC') ||
-              (['Stopped'].includes(record.state) && !['KVM', 'LXC'].includes(record.hypervisor)))
+          show: (record, store) => {
+            return (record.hypervisor !== 'KVM') ||


why destroyed state?

I tried to keep the UI conditions same as the service layer. Please see hostSupportsSnapsthotForVolume().

But I'm ok if we don't want to allow snapshot creation from UI for destroyed VMs.

Pearl1594 · 2024-10-10T01:02:42Z

ui/src/config/section/storage.js

-                record.hypervisor === 'KVM' && record.vmstate !== 'Running')
+            return record.state === 'Ready' &&
+              (record.hypervisor !== 'KVM' ||
+               ['Stopped', 'Destroyed'].includes(record.vmstate) ||


same here, why destroyed state ?

Same as above

Before this change, the button would be shown for all states part from 'Running'.
Now it will only be shown for 'Stopped' or 'Destroyed' states

Pearl1594 · 2024-10-10T01:02:57Z

ui/src/config/section/storage.js

-                record.hypervisor === 'KVM' && record.vmstate !== 'Running')
+            return record.state === 'Ready' &&
+              (record.hypervisor !== 'KVM' ||
+               (['Stopped', 'Destroyed'].includes(record.vmstate)) ||


same doubt as above

Same as above

blueorangutan · 2024-10-10T06:29:10Z

[SF] Trillian Build Failed (tid-11647)

rajujith

All the mentioned fixes works fine.

blueorangutan · 2024-12-04T10:45:03Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11710

DaanHoogland · 2024-12-04T11:55:18Z

@blueorangutan test

blueorangutan · 2024-12-04T11:56:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-12-05T03:22:44Z

[SF] Trillian test result (tid-11847)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53143 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9773-t11847-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_06_purge_expunged_vm_background_task	`Failure`	385.48	test_purge_expunged_vms.py
test_01_secure_vm_migration	`Error`	134.12	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	134.13	test_vm_life_cycle.py

DaanHoogland · 2024-12-05T08:43:51Z

@andrijapanicsb @rohityadavcloud , are your concerns dealt with, here? this seems ready for merge otherwise.

abh1sar · 2024-12-06T07:21:58Z

@blueorangutan package

blueorangutan · 2024-12-06T07:24:04Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-12-06T08:30:25Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 11735

abh1sar · 2024-12-06T09:14:13Z

@blueorangutan package

blueorangutan · 2024-12-06T09:16:03Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-12-06T10:30:37Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11737

abh1sar · 2024-12-06T14:26:13Z

@blueorangutan test

blueorangutan · 2024-12-06T14:28:04Z

@abh1sar a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-12-07T08:21:31Z

[SF] Trillian test result (tid-11862)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 62011 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9773-t11862-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_06_purge_expunged_vm_background_task	`Failure`	396.93	test_purge_expunged_vms.py
test_03_secured_to_nonsecured_vm_migration	`Error`	357.40	test_vm_life_cycle.py

abh1sar · 2024-12-17T02:24:43Z

@blueorangutan package

blueorangutan · 2024-12-17T02:26:04Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-12-17T03:39:35Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11825

rohityadavcloud · 2024-12-17T07:56:27Z

@blueorangutan test

blueorangutan · 2024-12-17T07:58:04Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-12-18T01:07:38Z

[SF] Trillian test result (tid-11925)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 59317 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9773-t11925-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_browser_migrate_template	`Error`	68.75	test_image_store_object_migration.py
test_06_purge_expunged_vm_background_task	`Failure`	400.79	test_purge_expunged_vms.py

abh1sar · 2024-12-18T09:00:30Z

@andrijapanicsb please check and let me know if you have more review comments.

abh1sar and others added 10 commits October 1, 2024 13:48

Show Usage Server configuration in a separate pane

eccb2e3

UI: Option to attach volume to an instance during create volume

fb46785

Merge branch '4.19'

c087de4

Show service ip in management server details tab

0a097c4

change Schedule Snapshots to Recurring Snapshots

0d024c3

Change the hypervisor order so that kvm, vmware, xenserver show up first

f53092e

Remove extra space in hypervisor names in config.java

a79b603

Fix updateTemplatePermission when the UI is set to a language other…

d6181d5

… than English (apache#9766) * Fix updateTemplatePermission UI in non-english language * Improve fix --------- Co-authored-by: Lucas Martins <[email protected]>

Autofill vcenter details in add cluster form

e666800

UI: condition to display create vm-vol-snapshots to same as create vo…

88ad004

…l-snapshots

boring-cyborg bot added the component:UI label Oct 6, 2024

abh1sar marked this pull request as draft October 6, 2024 18:14

DaanHoogland added the component:database label Oct 7, 2024

abh1sar added this to the 4.20.1.0 milestone Oct 8, 2024

rohityadavcloud reviewed Oct 8, 2024

View reviewed changes

abh1sar requested review from rajujith and andrijapanicsb October 8, 2024 12:04

Pearl1594 approved these changes Oct 10, 2024

View reviewed changes

rajujith reviewed Oct 10, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/main' into ui-improv

8fdfbdd

abh1sar marked this pull request as draft December 6, 2024 04:53

Update group_id in already present usage configuration settings

e7ffd8c

abh1sar marked this pull request as ready for review December 10, 2024 10:40

abh1sar added the status:ready-for-merge label Dec 10, 2024

Merge branch '4.20' into ui-improv

92a3dcd

abh1sar removed the status:ready-for-merge label Dec 18, 2024

abh1sar assigned abh1sar and andrijapanicsb and unassigned abh1sar Dec 18, 2024

UI improvements #9773

Are you sure you want to change the base?

UI improvements #9773

Conversation

abh1sar commented Oct 6, 2024 • edited Loading

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov bot commented Oct 6, 2024 • edited Loading

Codecov Report

abh1sar commented Oct 6, 2024

blueorangutan commented Oct 6, 2024

blueorangutan commented Oct 6, 2024

abh1sar commented Oct 7, 2024

blueorangutan commented Oct 7, 2024

blueorangutan commented Oct 7, 2024

DaanHoogland commented Oct 7, 2024

abh1sar commented Oct 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sureshanaparti Oct 30, 2024 • edited Loading

Choose a reason for hiding this comment

Pearl1594 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blueorangutan commented Oct 10, 2024

rajujith left a comment • edited Loading

Choose a reason for hiding this comment

blueorangutan commented Dec 4, 2024

DaanHoogland commented Dec 4, 2024

blueorangutan commented Dec 4, 2024

blueorangutan commented Dec 5, 2024

DaanHoogland commented Dec 5, 2024

abh1sar commented Dec 6, 2024

blueorangutan commented Dec 6, 2024

blueorangutan commented Dec 6, 2024

abh1sar commented Dec 6, 2024

blueorangutan commented Dec 6, 2024

blueorangutan commented Dec 6, 2024

abh1sar commented Dec 6, 2024

blueorangutan commented Dec 6, 2024

blueorangutan commented Dec 7, 2024

abh1sar commented Dec 17, 2024

blueorangutan commented Dec 17, 2024

blueorangutan commented Dec 17, 2024

rohityadavcloud commented Dec 17, 2024

blueorangutan commented Dec 17, 2024

blueorangutan commented Dec 18, 2024

abh1sar commented Dec 18, 2024

abh1sar commented Oct 6, 2024 •

edited

Loading

codecov bot commented Oct 6, 2024 •

edited

Loading

abh1sar commented Oct 8, 2024 •

edited

Loading

sureshanaparti Oct 30, 2024 •

edited

Loading

rajujith left a comment •

edited

Loading