Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update mockito major version #400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raboof
Copy link
Member

@raboof raboof commented Dec 30, 2024

Mockito 5 uses Java 11

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.

Mockito 5 uses Java 11
@garydgregory
Copy link
Member

Hmm, I was hoping to avoid customizing GH this way for builds here and there. I wonder if we should just put the Java 8 based version for this jar in the parent POM and avoid this. WDYT?

@raboof
Copy link
Member Author

raboof commented Dec 30, 2024

Hmm, I was hoping to avoid customizing GH this way for builds here and there. I wonder if we should just put the Java 8 based version for this jar in the parent POM and avoid this. WDYT?

It seems to be pretty widely used, so I guess that would make sense?

raboof added a commit to raboof/commons-parent that referenced this pull request Jan 2, 2025
So we only need to maintain the version to be the latest that supports
Java 8 here.

See also apache/commons-bcel#400
garydgregory pushed a commit to apache/commons-parent that referenced this pull request Jan 2, 2025
So we only need to maintain the version to be the latest that supports
Java 8 here.

See also apache/commons-bcel#400
@garydgregory
Copy link
Member

I don't think we need this change since commons-parent will define the Mockito version when the next version is released later today.

@raboof
Copy link
Member Author

raboof commented Jan 6, 2025

I agree (though we should replace it with a PR that uses the mockito version from the parent pom)

@garydgregory
Copy link
Member

garydgregory commented Jan 6, 2025

Hi @raboof
Once commons-parent is released, I'll kick off Dependabot builds and we'll first have to account for any changes due to the Doxia 1 to 2 upgrade, then we can clean up the Mockito references. In the meantime, would you help review the other Commons release candidates?

@raboof
Copy link
Member Author

raboof commented Jan 6, 2025

Hi @raboof Once commons-parent is released, I'll kick off Dependabot builds and we'll first have to account for any changes due to the Doxia 1 to 2 upgrade, then we can clean up the Mockito references.

👍

In the meantime, would you help review the other Commons release candidates?

* Codec: https://lists.apache.org/thread/66fvglm37rgt4hc8wzz6q3p5syctj1pf

will do

* BeanUtils 1: https://lists.apache.org/thread/g1xtov6k6w4ms2sb588f51z4y17dynz6

https://dist.apache.org/repos/dist/dev/commons/beanutils/1.10.0-RC1 seems to be missing?

@garydgregory
Copy link
Member

garydgregory commented Jan 6, 2025

https://dist.apache.org/repos/dist/dev/commons/beanutils/1.10.0-RC1 seems to be missing?

You're right, fixing... fixed: Committed revision 73999. I'll update the vote email with this revision number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants