-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't update mockito major version #400
base: master
Are you sure you want to change the base?
Conversation
Mockito 5 uses Java 11
Hmm, I was hoping to avoid customizing GH this way for builds here and there. I wonder if we should just put the Java 8 based version for this jar in the parent POM and avoid this. WDYT? |
It seems to be pretty widely used, so I guess that would make sense? |
So we only need to maintain the version to be the latest that supports Java 8 here. See also apache/commons-bcel#400
So we only need to maintain the version to be the latest that supports Java 8 here. See also apache/commons-bcel#400
I don't think we need this change since |
I agree (though we should replace it with a PR that uses the mockito version from the parent pom) |
Hi @raboof
|
👍
will do
https://dist.apache.org/repos/dist/dev/commons/beanutils/1.10.0-RC1 seems to be missing? |
You're right, fixing... fixed: Committed revision 73999. I'll update the vote email with this revision number. |
Mockito 5 uses Java 11
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn
; that'smvn
on the command line by itself.