Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove translation #1015

Closed
wants to merge 1 commit into from
Closed

chore: remove translation #1015

wants to merge 1 commit into from

Conversation

erisu
Copy link
Member

@erisu erisu commented Sep 5, 2019 •
edited
Loading

Motivation and Context

See #995

Description

  • Removes Translated Docs

closes: #995
closes: #932
closes: #841
closes: #759
closes: #742
closes: #735

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've deleted documentation that is necessary

@dblotsky
Copy link
Contributor

dblotsky commented Sep 5, 2019 via email

@janpio
Copy link
Member

janpio commented Sep 5, 2019

What happens to the old URLs - are they redirected to latest? Error message with proper 404 or 410?

@dblotsky dblotsky self-requested a review September 6, 2019 04:56
dblotsky
dblotsky suggested changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@dblotsky dblotsky left a comment •
edited by erisu
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we review this, I have 2 questions:

  • Why does this remove old docs versions? The original issue was only about translations.
  • What's the story for redirects?

@erisu
Copy link
Member Author

erisu commented Sep 6, 2019

@dblotsky

Sadly, telemetry did not exist in 5.4.0 or lower so I can not tell you for certain whats the % of users that uses 5.4.0 or less. Here is an example of what I see from the data we do have.

New Users (Sep 5th, 2019)
5.x => ???
6.5.0 => 1,673 (2%)
7.x => 8,065 (10%)
8.x => 21059 (25%)
9.x => 53,069 (63%)

Users out of 17,406 (Sep 3rd, 2019)
5.x => ???
6.5.0 => 2.06%
7.x => 7.63%
8.x => 32.54%
9.x => 57.22%

If there was users still using 5.x and we throw that into the mix, I am guess it would be 1% or less.

@erisu
Copy link
Member Author

erisu commented Sep 6, 2019 •
edited
Loading

@dblotsky

In the original ticket, after you raised up the concern, one of @raphinesse replies contained:

We should not put any effort into supporting old versions of Cordova let alone 10 translations of their docs.

I kinda took this into account and also removed versions but kept only a few based on the telemetry data.

If other are wanting to keep all versions or retain a bit more versions back, I can easily update the PR. This is why the deletion for versions was in a separate commit in this PR.

@erisu
Copy link
Member Author

erisu commented Sep 6, 2019

Here is also the telemetry link for reference: http://telemetry.cordova.io

@raphinesse
Copy link
Contributor

raphinesse commented Sep 6, 2019 •
edited
Loading

Well, then let's just remove the translations first. We can figure out what to do about those old versions later.

Thanks for taking care of this, @erisu.

@erisu erisu changed the title chore: remove translation and old docs chore: remove translation Sep 6, 2019
@erisu erisu requested a review from dblotsky September 6, 2019 07:33
@erisu
Copy link
Member Author

erisu commented Sep 6, 2019

Redirects to 404

dblotsky
dblotsky suggested changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@dblotsky dblotsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redirecting to 404 would be a pretty awful experience.

There is a bit of process for obsoleting pages: https://github.com/apache/cordova-docs/blob/master/doc/redirects.md.

But, I think obsoleting all translations is a big enough deal that we should:

  1. Announce it (e.g. in a blog post),
  2. Come up with a new redirect page, specifically for language deprecation.
  3. Have a roadmap to change the build system not to build for all those languages.

@janpio
Copy link
Member

janpio commented Sep 9, 2019

Come up with a new redirect page, specifically for language deprecation.

Here it would probably make sense to redirect to the EN version of everything.

@dblotsky
Copy link
Contributor

We have a deprecation page in many languages. We can use those at the very least. But, what do you guys think, from a user experience perspective, of a custom message in each language explaining why we decided to remove translations?

@raphinesse
Copy link
Contributor

raphinesse commented Nov 5, 2019 •
edited
Loading

Regarding your request for changes @dblotsky:

Redirecting to 404 would be a pretty awful experience.

Agreed.

I think obsoleting all translations is a big enough deal that we should:

  1. Announce it (e.g. in a blog post),

That would definitely be great to have.

  1. Come up with a new redirect page, specifically for language deprecation.

Here I would go with what @janpio proposed:

Here it would probably make sense to redirect to the EN version of everything.

I think this is more helpful than a redirect to a deprecation message. And it's very easy to implement. The following snippet added to www/.htaccess should do the job (untested):

# Redirect all docs translations to their English version
RewriteCond $1 !=en
RewriteRule ^.*docs/(\w\w(?:-\w\w)?)/(.*)$ {{site.baseurl}}/docs/en/$2 [R=301,L]
  1. Have a roadmap to change the build system not to build for all those languages.

IMHO, that is a matter of creating an issue titled Remove language support from build system but should not block us from going live with these changes. It can be addressed when someone finds the time to do so.

@brody4hire
Copy link

Any suggestions how we can move this forward?

Anything that I can do?

@dblotsky
Copy link
Contributor

@brodybits sorry for the delay, and thank you for patience!

I think the best way forward is the one that's easiest to review: so, as few changes at a time as possible.

I propose this plan (possibly as 4 sequential PRs, with a week between each):

  1. Announcing the deprecation in a blog post,
  2. Adding the redirects, deprecation pages, etc.,
  3. Actually deleting the translated pages (since the redirects made them unreachable), and
  4. Deleting the code that supports translations.

What do you think?

@erisu
Copy link
Member Author

erisu commented Aug 7, 2020

Closing, build or deploy performance at this time is not a priority.

@erisu erisu closed this Aug 7, 2020
@dblotsky dblotsky mentioned this pull request Aug 21, 2021
Merged
@breautek breautek mentioned this pull request Dec 23, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblotsky dblotsky dblotsky requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove all translations Properly translate paragraph into German About Chinese Simplified translation
5 participants
@erisu @dblotsky @janpio @raphinesse @brody4hire