fix: npm 8 does not install plugin dependencies #229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Installing Cordova Electron plugins does not install the Electron scope dependencies since npm 8.
Might be related to: npm/cli#2339
Description
This PR will
npm install
the sub-package dependencies before installing the sub-package to the Electron app scope.The only potential side-efect is a slight increase in performance, but this resolves the changes that were made in npm 7 or 8.
npm 8 will only create a symlink to the sub-package without installing.
Testing
npm t
cordova run
withcordova-plugin-device
installed.Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)