Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test with Node 16 instead of 15 for already correct version of npm@7 #94

Merged
merged 1 commit into from
Apr 26, 2021
Merged

ci: test with Node 16 instead of 15 for already correct version of npm@7 #94

merged 1 commit into from
Apr 26, 2021

Conversation

ath0mas
Copy link
Contributor

@ath0mas ath0mas commented Apr 25, 2021

Platforms affected

test

Motivation and Context

Node.js 16 is the future LTS and providing npm@7 > 7.2 already.

Description

Use of node 16.x to replace 15.x with custom npm@7 update from #91.

Testing

Local npm cit success on:

  • OS: Windows 10
  • Node: 16.0.0
  • npm: 7.10.0

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

node 16 as the future LTS and providing npm@7 already > 7.2
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2021

Codecov Report

Merging #94 (982e6d5) into master (f974d86) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files           1        1           
  Lines          60       60           
=======================================
  Hits           56       56           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f974d86...982e6d5. Read the comment docs.

@breautek
Copy link

Progresses apache/cordova#286

@breautek breautek mentioned this pull request Apr 25, 2021
33 tasks
@breautek breautek requested a review from raphinesse April 25, 2021 22:25
Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 approvals, merging!
Thanks for the contribution :)

@timbru31 timbru31 changed the title Test with Node 16 instead of 15 for already correct version of npm@7 ci: test with Node 16 instead of 15 for already correct version of npm@7 Apr 26, 2021
@timbru31 timbru31 merged commit 1b2e2e7 into apache:master Apr 26, 2021
@ath0mas ath0mas deleted the npm7-node16 branch April 29, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants