Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: support of CREATE VIEW IF NOT EXISTS #1118

Merged
merged 1 commit into from
Feb 4, 2024
Merged

BigQuery: support of CREATE VIEW IF NOT EXISTS #1118

merged 1 commit into from
Feb 4, 2024

Conversation

7phs
Copy link
Contributor

@7phs 7phs commented Jan 30, 2024

There is support for CREATE VIEW IF NOT EXISTS for general and sqlite dialects (only).

This PR adds a support it for BigQuery

alamb
alamb approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @7phs

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7712967930

  • -1 of 27 (96.3%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 87.668%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_bigquery.rs 25 26 96.15%
Totals Coverage Status
Change from base Build 7660582105: 0.01%
Covered Lines: 19507
Relevant Lines: 22251
💛 - Coveralls

@alamb alamb merged commit 60baea4 into apache:main Feb 4, 2024
10 checks passed
@alamb alamb mentioned this pull request Feb 4, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@7phs @coveralls @alamb