Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG.md for 0.52.0 release, add scripts/ instructions for ASF releases #1479

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Update CHANGELOG.md for 0.52.0 release, add scripts/ instructions for ASF releases #1479

merged 3 commits into from
Nov 7, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 21, 2024 •
edited
Loading

Part of #1423

This is the first release that will be officially voted / approved by the Apache voting process and this PR

  1. Updates the version to 0.52.0
  2. Adds the necessary scripts for making a release (based off what is in the datafusion repo)
  3. Adds instructions in dev/release/README.md

Draft until:

Following the directions results in this:

(venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/sqlparser-rs$ GITHUB_TOKEN=FOO ./dev/release/create-tarball.sh 0.52.0 2
Attempting to create  from tag v0.52.0-rc2
Draft email for [email protected] mailing list

---------------------------------------------------------
To: [email protected]
Subject: [VOTE] Release Apache DataFusion sqlparser-rs 0.52.0 RC2
Hi,

I would like to propose a release of Apache DataFusion sqlparser-rs version 0.52.0.

This release candidate is based on commit: 6b491c659ab8a350ee333f489251c7ce446af729 [1]
The proposed release tarball and signatures are hosted at [2].
The changelog is located at [3].

Please download, verify checksums and signatures, run the unit tests, and vote
on the release. The vote will be open for at least 72 hours.

Only votes from PMC members are binding, but all members of the community are
encouraged to test the release and vote with "(non-binding)".

The standard verification procedure is documented at https://github.com/apache/datafusion-sqlparser-rs/blob/main/dev/release/README.md#verifying-release-candidates.

[ ] +1 Release this as Apache DataFusion sqlparser-rs 0.52.0
[ ] +0
[ ] -1 Do not release this as Apache DataFusion sqlparser-rs 0.52.0 because...

Here is my vote:

+1

[1]: https://github.com/apache/datafusion-sqlparser-rs/tree/6b491c659ab8a350ee333f489251c7ce446af729
[2]: https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-sqlparser-rs-0.52.0-rc2
[3]: https://github.com/apache/datafusion-sqlparser-rs/blob/6b491c659ab8a350ee333f489251c7ce446af729/CHANGELOG.md

You can actually check out a release candidate I made here:

@alamb alamb changed the base branch from alamb/create_release_notes to main October 21, 2024 19:33
@alamb alamb changed the title Update CHANGELOG.md for 0.52.0 release Update CHANGELOG.md for 0.52.0 release, update instructions for ASF releases Oct 21, 2024
@alamb alamb mentioned this pull request Oct 21, 2024
Closed
4 tasks
@alamb alamb mentioned this pull request Nov 6, 2024
Merged
@alamb alamb force-pushed the alamb/create_release_notes branch from bb80c78 to 1f904b1 Compare November 6, 2024 21:05
@alamb alamb mentioned this pull request Nov 6, 2024
Merged
@alamb alamb changed the title Update CHANGELOG.md for 0.52.0 release, update instructions for ASF releases Update CHANGELOG.md for 0.52.0 release, add scripts/ instructions for ASF releases Nov 6, 2024
@alamb alamb force-pushed the alamb/create_release_notes branch 4 times, most recently from a36bef8 to e9e1e63 Compare November 6, 2024 21:51
@alamb alamb force-pushed the alamb/create_release_notes branch from e9e1e63 to a4aa6e2 Compare November 6, 2024 21:52
alamb
alamb commented Nov 6, 2024
View reviewed changes
changelog/0.52.0.md
under the License.
-->

# sqlparser-rs 0.52.0 Changelog
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is made with an excellent script originally written by @andygrove for DataFusion ❤️

dev/release/README.md
-->


## Process Overview
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is liberally based off (aka copy/paste) from https://github.com/apache/datafusion/blob/main/dev/release/README.md

docs/releasing.md
@@ -1,81 +0,0 @@
<!---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed old version of release instructions

Cargo.toml
version = "0.51.0"
authors = ["Andy Grove <[email protected]>"]
homepage = "https://github.com/sqlparser-rs/sqlparser-rs"
version = "0.52.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to reflect apache author (sorry @andygrove !)

dev/release/check-rat-report.py
@@ -0,0 +1,59 @@
#!/usr/bin/python
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied from datafusion without modification

dev/release/verify-release-candidate.sh
@@ -0,0 +1,152 @@
#!/bin/bash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and it seems to work

@alamb alamb marked this pull request as ready for review November 6, 2024 21:54
@alamb alamb requested review from andygrove and iffyio November 6, 2024 21:54
@alamb alamb mentioned this pull request Nov 6, 2024
Closed
iffyio
iffyio approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alamb
Copy link
Contributor Author

alamb commented Nov 7, 2024

Thanks @iffyio -- Let's get this in and give making a release a try!

@alamb alamb merged commit 334a5bf into apache:main Nov 7, 2024
8 checks passed
@alamb
Copy link
Contributor Author

alamb commented Nov 7, 2024

🚀

@alamb alamb deleted the alamb/create_release_notes branch November 7, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iffyio iffyio iffyio approved these changes

@andygrove andygrove Awaiting requested review from andygrove

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alamb @iffyio