-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for FROM <filename>
, DELIMITER
, and CSV HEADER
options for COPY
command
#409
Conversation
Pull Request Test Coverage Report for Build 1801328813
💛 - Coveralls |
FROM <filename>
, DELIMITER
, and CSV HEADER
options for COPY
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @poonai . I had a question about CSV HEADER
the lint CI failures should be resolved if you merge
up to main
filename: Option<Ident>, | ||
/// delimiter character | ||
delimiter: Option<Ident>, | ||
/// CSV HEADER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think CSV HEADER
was part of the syntax. Postgres seems to only support HEADER
:
https://www.postgresql.org/docs/13/sql-copy.html
I think CSV is used as part of the FORMAT option, like
COPY ... FORMAT CSV ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: password <[email protected]>
Signed-off-by: password <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @poonai for the contribution. If/when people want further support for COPY options, we can always add it as a follow on PR
This PR adds support for delimiter and csv header options in copy command
Signed-off-by: password [email protected]