Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix clippy error in ci #803

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Conversation

togami2864
Copy link
Contributor

@togami2864 togami2864 commented Feb 3, 2023

To avoid clippy error like #802 in CI.
Maybe this ci error has affected by rust-lang/rust-clippy#10265

@coveralls
Copy link

coveralls commented Feb 3, 2023

Pull Request Test Coverage Report for Build 4081311050

  • 311 of 357 (87.11%) changed or added relevant lines in 14 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 86.052%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/value.rs 8 9 88.89%
src/test_utils.rs 0 1 0.0%
src/ast/query.rs 42 45 93.33%
src/tokenizer.rs 15 18 83.33%
tests/sqlparser_postgres.rs 2 7 28.57%
src/ast/visitor.rs 0 6 0.0%
src/parser.rs 2 9 22.22%
src/ast/mod.rs 178 198 89.9%
Files with Coverage Reduction New Missed Lines %
src/ast/query.rs 1 85.59%
src/lib.rs 1 10.02%
src/parser.rs 1 83.29%
src/ast/mod.rs 2 78.02%
Totals Coverage Status
Change from base Build 3975768953: 0.1%
Covered Lines: 13197
Relevant Lines: 15336

💛 - Coveralls

@togami2864
Copy link
Contributor Author

I fixed this but it also might be good simply disable this rule.

Copy link
Contributor

@AugustoFKL AugustoFKL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, only linter fixes

Thanks!

@AugustoFKL
Copy link
Contributor

@alamb, can this be approved before other PRs, please?

It seems like Rust had an update, so other PR's linters are failing.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @togami2864 and @AugustoFKL

@alamb alamb merged commit b31ede7 into apache:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants