Require sort expressions to be of type Sort (#12171)

* Require sort expressions to be of type Sort in compare_sort_expr

* fixup! Require sort expressions to be of type Sort in compare_sort_expr

* fixup! Require sort expressions to be of type Sort in compare_sort_expr

datafusion/expr/src/utils.rs

@@ -569,7 +569,7 @@ pub fn compare_sort_expr(
             }
             Ordering::Equal
         }
-        _ => Ordering::Equal,
+        _ => panic!("Sort expressions must be of type Sort"),
     }
 }
 

datafusion/sql/src/expr/function.rs

@@ -295,8 +295,10 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
                             Some(false)
                         };
                     }
+                    Some(false)
+                } else {
+                    panic!("order_by expression must be of type Sort");
                 }
-                Some(false)
             });
 
             let window_frame = window

datafusion/sql/src/unparser/rewrite.rs

@@ -161,6 +161,8 @@ pub(super) fn rewrite_plan_for_sort_on_non_projected_fields(
     for expr in &sort.expr {
         if let Expr::Sort(s) = expr {
             collects.push(s.expr.as_ref().clone());
+        } else {
+            panic!("sort expression must be of type Sort");
         }
     }