Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFusion compilation error with --no-default-features #1217

Closed
alamb opened this issue Nov 1, 2021 · 1 comment · Fixed by #1219
Closed

DataFusion compilation error with --no-default-features #1217

alamb opened this issue Nov 1, 2021 · 1 comment · Fixed by #1219
Labels
bug Something isn't working

Comments

@alamb
Copy link
Contributor

alamb commented Nov 1, 2021

Describe the bug
DataFusion no longer compiles without default features:

To Reproduce

cargo test --no-default-features -p datafusion
   Compiling datafusion v5.1.0 (/Users/alamb/Software/arrow-datafusion/datafusion)
error[E0432]: unresolved import `crate::physical_plan::file_format::DEFAULT_PARTITION_COLUMN_DATATYPE`
  --> datafusion/src/datasource/listing/table.rs:31:43
   |
31 |         file_format::{PhysicalPlanConfig, DEFAULT_PARTITION_COLUMN_DATATYPE},
   |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `DEFAULT_PARTITION_COLUMN_DATATYPE` in `physical_plan::file_format`

error: cannot find macro `lazy_static` in this scope
  --> datafusion/src/physical_plan/file_format/mod.rs:51:1
   |
51 | lazy_static! {
   | ^^^^^^^^^^^

error[E0425]: cannot find value `DEFAULT_PARTITION_COLUMN_DATATYPE` in this scope
   --> datafusion/src/physical_plan/file_format/mod.rs:108:21
    |
108 |                     DEFAULT_PARTITION_COLUMN_DATATYPE.clone(),
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find value `DEFAULT_PARTITION_COLUMN_DATATYPE` in this scope
   --> datafusion/src/physical_plan/file_format/mod.rs:267:34
    |
267 |     debug_assert_eq!(data_type, *DEFAULT_PARTITION_COLUMN_DATATYPE);
    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

Some errors have detailed explanations: E0425, E0432.

Expected behavior
Datafusion should compile

Additional context
I suspect this came in via #1141

@alamb alamb added the bug Something isn't working label Nov 1, 2021
@alamb
Copy link
Contributor Author

alamb commented Nov 1, 2021

I believe the issue is that lazy_static is declared as an optional dependency but it is no longer optional

cargo test --no-default-features --features=regex_expressions -p datafusion 

does work

andygrove added a commit to andygrove/datafusion that referenced this issue Jan 31, 2025
…ouping (apache#1217)

* extract static invoke expressions to folders based on spark grouping

* Update native/spark-expr/src/static_invoke/mod.rs

Co-authored-by: Andy Grove <[email protected]>

---------

Co-authored-by: Andy Grove <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant