-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor: Document LogicalPlan tree node transformations #10010
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Logical plan and expressions
core
Core DataFusion crate
labels
Apr 9, 2024
alamb
force-pushed
the
alamb/logical_plan_rewrite_docs
branch
from
April 9, 2024 11:33
6bea98c
to
68277a1
Compare
alamb
force-pushed
the
alamb/logical_plan_rewrite_docs
branch
from
April 9, 2024 11:45
68277a1
to
93cb18e
Compare
github-actions
bot
removed
the
documentation
Improvements or additions to documentation
label
Apr 9, 2024
alamb
changed the title
Document LogicalPlan tree node transformations
Minor: Document LogicalPlan tree node transformations
Apr 9, 2024
andygrove
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thansk @alamb. This is very helpful, especially now that we have so much functionality in this area.
github-actions
bot
removed
the
documentation
Improvements or additions to documentation
label
Apr 10, 2024
Thanks for the review @andygrove -- I added 2 more functions to the list. |
🚀 📖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #9994
Rationale for this change
Part of working with optimizers /
LogicalPlans
is understanding how to rewrite them and visit themWe are improving this in #8913, so I wanted to make sure the feature is well documented.
What changes are included in this PR?
LogicalPlan
tree node apiAre these changes tested?
Yes, by CI checks
Are there any user-facing changes?
Better docs
TODO:
2. Document apply_subqueries /map_subqueries: #9998