Rename FileSinkExec to DataSinkExec
#10065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
devinjdangelo
approved these changes
Apr 12, 2024
alamb
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
Thank you very much @phillipleblanc for the contribution and @devinjdangelo for the review
| @@ -74,10 +74,13 @@ pub trait DataSink: DisplayAs + Debug + Send + Sync { | |||
| ) -> Result<u64>; | |||
| } | |||
|
|
|||
| #[deprecated(since = "38.0.0", note = "Use [`DataSinkExec`] instead")] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10064
Rationale for this change
Reduces confusion among new users of the DataFusion library that want a general purpose insert execution plan. See discussion #9940
What changes are included in this PR?
Renames
FileSinkExectoDataSinkExecand adds a typedef forFileSinkExecwith a deprecation notice.Are these changes tested?
Yes, by CI
Are there any user-facing changes?
Yes, users should update their usage of FileSinkExec to DataSinkExec.