Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] make parquet prune tests more readable #10112

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

Ted-Jiang
Copy link
Member

Which issue does this PR close?

Closes #10111.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Apr 17, 2024
@Ted-Jiang Ted-Jiang closed this Apr 17, 2024
@Ted-Jiang Ted-Jiang reopened this Apr 17, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 -- this looks so much nicer @Ted-Jiang

RowGroup,
Page,
// pass max row per row_group in parquet writer
RowGroup(usize),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is much nicer to read -- thank you @Ted-Jiang

@alamb alamb merged commit dea4a1b into apache:main Apr 17, 2024
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[minor] make parquet prune tests more readable
2 participants