Add distinct aggregate tests to sqllogictest #10158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI we don't support this But maybe can tackle as separate issue from those original issues 🤔 See #10159 (comment) |
If it hasn't been implemented yet, we should add them to sqllogictest and return an error first. |
|
Done. Also I'll keep the original issues open. |
Weijun-H
approved these changes
Apr 21, 2024
|
Thanks @Jefffrey and @Weijun-H and @jayzhan211 🚀 |
ccciudatu
pushed a commit
to hstack/arrow-datafusion
that referenced
this pull request
Apr 26, 2024
* Add distinct aggregate tests to sqllogictest * Update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates to #2411, #2410, #2408
Rationale for this change
Datafusion already supports these use cases. Just locking them into the test suite
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?