Minor: Introduce Expr::is_volatile(), adjust TreeNode::exists()
#10191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
peter-toth
changed the title
Expr::is_volatile(), adjust TreeNode::exists()Expr::is_volatile(), adjust TreeNode::exists()
alamb
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Looks like a very nice improvement to me -- thank you @peter-toth
| @@ -405,18 +405,17 @@ pub trait TreeNode: Sized { | |||
| /// Returns true if `f` returns true for any node in the tree. | |||
| /// | |||
| /// Stops recursion as soon as a matching node is found | |||
| fn exists<F: FnMut(&Self) -> bool>(&self, mut f: F) -> bool { | |||
| fn exists<F: FnMut(&Self) -> Result<bool>>(&self, mut f: F) -> Result<bool> { | |||
| @@ -97,20 +95,6 @@ pub fn log_plan(description: &str, plan: &LogicalPlan) { | |||
| trace!("{description}::\n{}\n", plan.display_indent_schema()); | |||
| } | |||
|
|
|||
| /// check whether the expression is volatile predicates | |||
|
Thanks for the review! |
ccciudatu
pushed a commit
to hstack/arrow-datafusion
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
Expr::is_volatile()instead ofis_volatile_expression(e: &Expr).Also, a small change is needed to
TreeNode::exists(), that it is a fairly new API, and the change makes it more versatile.