-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update release scripts to reflect move to TLP #10235
Conversation
@@ -128,7 +128,7 @@ release. | |||
|
|||
See [#9697](https://github.com/apache/datafusion/pull/9697) for an example. | |||
|
|||
Here are the commands that could be used to prepare the `5.1.0` release: | |||
Here are the commands that could be used to prepare the `38.0.0` release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to get rid of hardcoded versions somehow....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should really try and automate more of the release process so that we just run scripts and pass in the version number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One way to to so might be to make a script that just does all of this (rather than having manual instructions). And then the script could have $VERSION
or whatever
``` | ||
|
||
Delete a release: | ||
|
||
```bash | ||
svn delete -m "delete old DataFusion release" https://dist.apache.org/repos/dist/release/datafusion/datafusion-7.0.0 | ||
svn delete -m "delete old DataFusion release" https://dist.apache.org/repos/dist/release/datafusion/datafusion-37.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
svn delete -m "delete old DataFusion release" https://dist.apache.org/repos/dist/release/datafusion/datafusion-37.0.0 | |
svn delete -m "delete old DataFusion release" https://dist.apache.org/repos/dist/release/datafusion/datafusion-38.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks @andygrove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- thanks @andygrove -- I think we should merge this PR and then be careful during our next release (and update anything that we missed)
Thank you for this
@@ -128,7 +128,7 @@ release. | |||
|
|||
See [#9697](https://github.com/apache/datafusion/pull/9697) for an example. | |||
|
|||
Here are the commands that could be used to prepare the `5.1.0` release: | |||
Here are the commands that could be used to prepare the `38.0.0` release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One way to to so might be to make a script that just does all of this (rather than having manual instructions). And then the script could have $VERSION
or whatever
@@ -15,84 +15,8 @@ ci/etc/*.patch | |||
ci/vcpkg/*.patch | |||
CHANGELOG.md | |||
datafusion/CHANGELOG.md | |||
python/CHANGELOG.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Which issue does this PR close?
Closes #10134
Rationale for this change
The release scripts needed updating now that DataFusion is a TLP
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?