Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Error for Unnest Rewritter #10263

Merged
merged 2 commits into from
Apr 29, 2024
Merged

chore: Update Error for Unnest Rewritter #10263

merged 2 commits into from
Apr 29, 2024

Conversation

Weijun-H
Copy link
Member

@Weijun-H Weijun-H commented Apr 27, 2024 •
edited
Loading

Which issue does this PR close?

Relate #10040

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label Apr 27, 2024
alamb
alamb approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Weijun-H !

I wonder if there is any easy way to write a reproducer for this (aka an .slt test that provokes this error, to make sure we don't break it again in the future) 🤔

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Apr 28, 2024
@comphead comphead merged commit 1c0ecf6 into apache:main Apr 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Weijun-H @alamb @comphead